gh-117613: Argument Clinic: disallow defining_class parameter at module level#117950
Merged
erlend-aasland merged 8 commits intopython:mainfrom Apr 17, 2024
neonene:ac313
Merged
gh-117613: Argument Clinic: disallow defining_class parameter at module level#117950erlend-aasland merged 8 commits intopython:mainfrom neonene:ac313
defining_class parameter at module level#117950erlend-aasland merged 8 commits intopython:mainfrom
neonene:ac313
Conversation
vstinner
reviewed
Apr 16, 2024
neonene
changed the title
defining_class parameter inside a module blockdefining_class parameter at module level
Contributor
Author
|
I cannot investigate the mypy error right now, failing to build mypy on 3.13. |
Contributor
I can take a look. Would you like me to update the PR for you? |
Contributor
Author
|
Thank you. I just managed to install mypy. I'll try it a bit more. |
Contributor
Author
|
Please check. |
erlend-aasland
approved these changes
Apr 17, 2024
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows #117781.
cc @vstinner @erlend-aasland
defining_classand no slash #117613